Skip to content

e2e tests: Fix leaky timer#2745

Merged
mergify[bot] merged 1 commit intojg/semgrep_4from
jg/fix_existing_issue_in_semgrep
Jun 10, 2022
Merged

e2e tests: Fix leaky timer#2745
mergify[bot] merged 1 commit intojg/semgrep_4from
jg/fix_existing_issue_in_semgrep

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Jun 10, 2022

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2022

⚠️ No Changeset found

Latest commit: 73094ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and mslipper June 10, 2022 04:33
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify mergify bot requested a review from Inphi June 10, 2022 04:56
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 2831ec0 into jg/semgrep_4 Jun 10, 2022
@mergify mergify bot deleted the jg/fix_existing_issue_in_semgrep branch June 10, 2022 04:56
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 10, 2022
mergify bot added a commit that referenced this pull request Jun 10, 2022
@trianglesphere @mergify
CI: Update semgrep rules & config (#2739)
d1c24a9 
* CI: Update semgrep rules & config

* e2e tests: Fix leaky timer (#2745)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
roninjin10 pushed a commit that referenced this pull request Jun 10, 2022
@trianglesphere @mergify
CI: Update semgrep rules & config (#2739)
27e75d7 
* CI: Update semgrep rules & config

* e2e tests: Fix leaky timer (#2745)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
feat(node/test): connection drop test + restart test (#2745)
4400677 
## Description

This PR adds back the connection drop test and the restart test inside
our e2e testing suite

See #2554 and #2553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper mslipper approved these changes

@Inphi Inphi Awaiting requested review from Inphi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trianglesphere @mslipper @Inphi